Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug 2370 #2371

Merged
merged 2 commits into from
Apr 24, 2023
Merged

fix bug 2370 #2371

merged 2 commits into from
Apr 24, 2023

Conversation

elizabethdinella
Copy link
Contributor

fixes #2370

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ethereum/solidity#14142 (comment)

this error is due to a bug on that release and the proper support for constantinoble EVM version through the command line was only added in version 0.4.22. See: ethereum/solidity@a59d6d2 and ethereum/solidity#3713

nice find!
please add a short explanation to the docs why we use 0.4.22 but link to the 0.4.21 release:

we have a failing test, could you please check if we need another 0.4.21 constant for this?

proper support for constantinoble EVM version through the command line was only added in version 0.4.22

I'm not sure if this affects the standard-json input

// the EVM version flag was only added at 0.4.21
// we work our way backwards
if version >= &CONSTANTINOPLE_SOLC {

@elizabethdinella
Copy link
Contributor Author

Can you point me to where to update the docs?

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

failing tests #2361

@prestwich prestwich merged commit 0d2ab90 into gakonst:master Apr 24, 2023
11 of 15 checks passed
@prestwich
Copy link
Collaborator

Thanks for the contribution!

Can you point me to where to update the docs?

Docs can be updated in the /// rustdoc above the relevant code items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

solc version 0.4.21 does not support Constantinople
3 participants