Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add back ethers-solc feature for ethers #2376

Merged
merged 2 commits into from
Apr 25, 2023
Merged

fix: add back ethers-solc feature for ethers #2376

merged 2 commits into from
Apr 25, 2023

Conversation

DaniPopes
Copy link
Collaborator

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

prestwich
prestwich approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@prestwich prestwich left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L G T M
(concept ACK, obv compilation issue needs to be fixed)

@prestwich prestwich merged commit 3bd4929 into gakonst:master Apr 25, 2023
15 checks passed
@DaniPopes DaniPopes deleted the fix/gate-solc branch April 25, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DaniPopes @prestwich