Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: specify sum type in abigen to avoid ambiguity #2383

Merged
merged 1 commit into from
Apr 28, 2023
Merged

fix: specify sum type in abigen to avoid ambiguity #2383

merged 1 commit into from
Apr 28, 2023

Conversation

prestwich
Copy link
Collaborator

Motivation

https://github.com/grantweii/ethers-macro-bug

Solution

Specify the output of the sum to avoid ambiguity when other types implementing Sum<usize> are in scope

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the bug Something isn't working label Apr 28, 2023
@prestwich prestwich self-assigned this Apr 28, 2023
@prestwich
Copy link
Collaborator Author

CI failure is unrelated

@prestwich prestwich merged commit 68bc044 into master Apr 28, 2023
14 of 15 checks passed
@prestwich prestwich deleted the prestwich/specify-sum-type branch April 28, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees

@prestwich prestwich

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prestwich @mattsse