-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the eip712 feature flag and have it enabled by default #2409
Conversation
Forgot to set nightly - it was reverted with the next commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you keep the feature just in the Cargo.toml
, to avoid breakage for now? It will be removed in the next major bump (e.g. for '3.0').
Sorry I have overloaded the PR for clippy fixes as well |
@@ -58,6 +58,3 @@ legacy = [] | |||
|
|||
rustls = ["ethers-contract-abigen/rustls"] | |||
openssl = ["ethers-contract-abigen/openssl"] | |||
|
|||
# Deprecated | |||
eip712 = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add them back here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, yep.
@@ -70,6 +70,3 @@ rand.workspace = true | |||
celo = ["legacy"] # celo support extends the transaction format with extra fields | |||
legacy = [] | |||
macros = ["syn", "cargo_metadata", "once_cell"] | |||
|
|||
# Deprecated | |||
eip712 = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep the flag in the Cargo.toml. Removing it will break compilation for library consumers
@@ -10,10 +10,6 @@ other utilities for interacting with the Ethereum ecosystem | |||
|
|||
For more information, please refer to the [book](https://gakonst.com/ethers-rs). | |||
|
|||
## Feature flags | |||
|
|||
- `eip712`: Provides the `Eip712` trait and derive procedural macro for EIP-712 encoding of typed data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modify to say "does nothing"
@@ -69,7 +69,6 @@ impl fmt::Display for Signature { | |||
} | |||
} | |||
|
|||
#[cfg(feature = "eip712")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
combine with main impl block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Motivation
Closes #2408
Solution
Remove feature flag enabling by default.
PR Checklist