Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: reduce (circular) dev dependencies #2415

Merged
merged 1 commit into from
May 15, 2023
Merged

test: reduce (circular) dev dependencies #2415

merged 1 commit into from
May 15, 2023

Conversation

DaniPopes
Copy link
Collaborator

Motivation

Solution

  • Remove ethers-solc from ethers-contract{,-abigen} by compiling files manually
  • Remove ethers-signers from ethers-contract by moving the only test using it (test_derive_eip712) to ethers-middleware, which has all the needed dependencies

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

mattsse
mattsse approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

@DaniPopes DaniPopes merged commit 4b6fc29 into gakonst:master May 15, 2023
1 of 15 checks passed
@DaniPopes DaniPopes deleted the test/deps branch May 15, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DaniPopes @mattsse