add subscribe_full_pending_txs() #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM too; waiting for the merge |
|
fyi @DaniPopes |
DaniPopes
requested changes
May 23, 2023
ethers-providers/src/middleware.rs
Outdated
Comment on lines
923
to
929
| /// Subscribe to a stream of pending transaction bodies. | ||
| /// | ||
| /// This function is only available on pubsub clients, such as Websockets | ||
| /// or IPC. For a polling alternative available over HTTP, use | ||
| /// [`Middleware::watch_pending_transactions`]. However, be aware that | ||
| /// polling increases RPC usage drastically. | ||
| async fn subscribe_full_pending_txs( |
There was a problem hiding this comment.
Can you document that this API will only work on Geth >=X.Y.Z?
There was a problem hiding this comment.
this is also not available on all providers or is specific to tiers.
so essentially the same as all the tracing APIs.
There was a problem hiding this comment.
Can you document that this API will only work on Geth
>=X.Y.Z?
added :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
geth recently added SubscribeFullPendingTransactions
this PR just adds a new method called
subscribe_full_pending_txs(), which instead of streaming hashes, streamswhole tx bodies. the only edit was adding
trueas a additional parameter, sosubscribe([utils::serialize(&"newPendingTransactions"), utils::serialize(&true)]).PR Checklist