Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nonce helper function #2429

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

dennohpeter
Copy link
Contributor

@dennohpeter dennohpeter commented May 24, 2023

Add a helper function to override nonce in contact FunctionCall

Motivation

Currently, there is no way to override nonce from the contract FunctionCall struct. It would be useful to make it easier to override nonce too as it is with value, gas and gas price

Solution

I added a helper function to set the nonce, so it can be overridden before a transaction is submitted.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@dennohpeter dennohpeter changed the title added nonce helper function add nonce helper function May 24, 2023
@dennohpeter dennohpeter changed the title add nonce helper function feat: add nonce helper function May 25, 2023
@dennohpeter
Copy link
Contributor Author

@mattsse

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

I believe this builder function was just missing

@DaniPopes

Copy link
Collaborator

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DaniPopes DaniPopes merged commit 6708c1f into gakonst:master May 25, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants