Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Optimism deposited transactions (2nd part) #2434

Merged
merged 38 commits into from
May 29, 2023
Merged

feat: Optimism deposited transactions (2nd part) #2434

merged 38 commits into from
May 29, 2023

Conversation

merklefruit
Copy link
Contributor

@merklefruit merklefruit commented May 26, 2023 •
edited

Part of #2390.
(Please see the last comments on #2390 to understand why this is labeled as "2nd part")

  • Added the OptimismDepositedTransactionRequest struct
  • Added the corresponding TypedTransaction::OptimismDeposited variant
  • Added the #[cfg(feature = "optimism")] feature flag everywhere needed
  • Added simple RLP encoding & decoding tests

ncitron and others added 30 commits March 29, 2023 15:52
@ncitron
ad op deposited txs
d74bd94
@ncitron
fix input rlp
ca7e9dc
@ncitron
fix is_system_tx type
54f6f88
@ncitron
make source hash optional
1b59b68
@merklefruit
Merge branch 'optimism-support' of github.com:ncitron/ethers-rs into …
da54e2e 
…optimism-txs
@merklefruit
chore: fix tests
5d7da2d
@merklefruit
fix: add tx type encoding
01c78d1
@merklefruit
fix: optimism deposit tx rlp
1d45f33
@merklefruit
chore: type encoding
77ebd62
@merklefruit
wip: fix rlp encoding for op
7890de8
@merklefruit
feat: cleanup test
2324524
@merklefruit
chore: removed dbg
8415fd4
@merklefruit
feat: added optimism feature
00071e3
@merklefruit
chore: forgot match arm feature
746bd6c
@merklefruit
chore: examples crate readded
3c01f80
@merklefruit
chore: added feature to main cargo toml
5f0f257
@merklefruit
feat: added docs
3f8a97a
@merklefruit
chore: added serde default
78ce957
@merklefruit
chore: docs: mutually exclusive features
b87fb80
@merklefruit
chore: readme
8359a5d
@merklefruit
chore: rlp opt
c4206f9
@merklefruit
chore: merged conflicts
df01f20
@merklefruit
wip: adding 0x7E tx request type
62bdf13
@merklefruit
chore: comment
fb8397f
@merklefruit
feat: added optimism feature flag everywhere
4c34f99
@merklefruit
feat: added RLP tests
91d656c
@merklefruit
chore: pull from master
dea7c66
@merklefruit
fix: missed tx branch
bb64439
@merklefruit
feat: added optimism dependency to other packages
8c31a55
@merklefruit
chore: missing feature flags
fff2bd8
@DaniPopes
Copy link
Collaborator

Can you rebase to latest master? I've updated CI to run checks and tests with the optimism feature in #2436

@DaniPopes DaniPopes merged commit 8ea944b into gakonst:master May 29, 2023
18 checks passed
@mdehoog mdehoog mentioned this pull request Oct 20, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@merklefruit @DaniPopes @ncitron