Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contract): support state overrides for Multicall #2478

Merged

Conversation

zzhengzhuo
Copy link
Contributor

@zzhengzhuo zzhengzhuo commented Jun 16, 2023

Motivation

Closes #2474

It would be nice to support state overrides for MultiCall.

Solution

Implement RawCall for MultiCall.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Collaborator

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. Will need to rebase and fix clippy lint.

@zzhengzhuo zzhengzhuo force-pushed the feat-support-state-overrides-for-multicall branch from c4e9174 to 94c9656 Compare August 18, 2023 02:16
@zzhengzhuo zzhengzhuo force-pushed the feat-support-state-overrides-for-multicall branch from 94c9656 to cd5e13f Compare August 18, 2023 04:35
@zzhengzhuo
Copy link
Contributor Author

@DaniPopes Fixed

Copy link
Collaborator

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DaniPopes DaniPopes merged commit 5fc33e3 into gakonst:master Aug 18, 2023
19 checks passed
@zzhengzhuo zzhengzhuo deleted the feat-support-state-overrides-for-multicall branch August 21, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support state overrides for MultiCall
2 participants