Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add base network #2516

Merged
merged 1 commit into from
Jul 25, 2023
Merged

feat: add base network #2516

merged 1 commit into from
Jul 25, 2023

Conversation

sakulstra
Copy link
Contributor

Motivation

I wanted to use Base & noticed wrong config for BaseGoerli as it has also undergone bedrock

Solution

I added base & fixed the config

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

mattsse
mattsse approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaniPopes DaniPopes merged commit 2934792 into gakonst:master Jul 25, 2023
16 of 19 checks passed
@Evalir Evalir mentioned this pull request Jul 25, 2023
Closed
aathan pushed a commit to aathan/ethers-rs that referenced this pull request Jul 27, 2023
@sakulstra
feat: add base network (gakonst#2516)
78e78b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sakulstra @mattsse @DaniPopes