chore: support latest svm #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Jul 24, 2023
|
we don't commit the lockfile ser |
mattsse
reviewed
Jul 24, 2023
mattsse
requested changes
Jul 24, 2023
Comment on lines
+227
to
+234
| Some(dir) => { | ||
| if !dir.exists() { | ||
| dirs::data_dir().map(|dir| dir.join("svm")) | ||
| } else { | ||
| Some(dir) | ||
| } | ||
| } | ||
| None => dirs::data_dir().map(|dir| dir.join("svm")), |
There was a problem hiding this comment.
Isn't this also just SVM_DATA_DIR now?
can we use this instead?
There was a problem hiding this comment.
Ah, the problem with using this directly is that we'd lock the crate to use svm always instead of conditionally (it's currently a feature)
|
@mattsse done, but current failure seems unrelated? |
|
yeah unrelated geth snafu @DaniPopes mind merging this wen you find the time? |
mattsse
approved these changes
Jul 24, 2023
DaniPopes
approved these changes
Jul 24, 2023
aathan
pushed a commit
to aathan/ethers-rs
that referenced
this pull request
Jul 27, 2023
* fix: use SVM_DATA_DIR instead of SVM_HOME * chore: update test * chore: use correct folder if exists * fix: change svm home folder detection * clippy * actually check if path exists or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Due to alloy-rs/svm-rs@9b0fa3a#diff-4ac4c674e2696c0c39e91b7ba5af3f65b6ffb1a0fa9b90d3f9930a14254ecb98L126 some changes are needed to point to the correct var here, as
SVM_HOMEdoes not exist anymoreSolution
Use
SVM_DATA_DIRPR Checklist