feat: add engine api-compatible bearer token generation #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
DaniPopes
requested changes
Jul 29, 2023
Comment on lines
304
to
307
| /// Returns a reference to the underlying byte array. | ||
| pub fn as_bytes(&self) -> &[u8] { | ||
| &self.0 | ||
| } |
There was a problem hiding this comment.
Needs a way to get the underlying bytes back
Suggested change
| /// Returns a reference to the underlying byte array. | |
| pub fn as_bytes(&self) -> &[u8] { | |
| &self.0 | |
| } | |
| /// Returns a reference to the underlying byte array. | |
| pub fn as_bytes(&self) -> &[u8; JWT_SECRET_LENGTH] { | |
| &self.0 | |
| } | |
| pub fn into_bytes(self) ... |
DaniPopes
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I was looking for a way to easily make engine API calls using ethers-rs /
cast, and realized that there is no JWT signing / encoding, the token would have to be generated elsewhere, before usingAuthorization::Bearer.Solution
This adds code used by lighthouse to communicate with an EL's engine API:
https://github.com/sigp/lighthouse/blob/dfcb3363c757671eb19d5f8e519b4b94ac74677a/beacon_node/execution_layer/src/engine_api/auth.rs#L132
PR Checklist