Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(solc): memoize is_dirty results #2550

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

DaniPopes
Copy link
Collaborator

@DaniPopes DaniPopes commented Aug 11, 2023

Motivation

Hot code path that contributes to ~30% of the time spent preparing for a compiler run in forge

cc @mattsse

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!
think this looks correct to me, even if the cache tests pass I'd feel a bit more confident if we can try this in foundry first via a patch PR first before merging

@DaniPopes
Copy link
Collaborator Author

foundry-rs/foundry#5607

@mattsse
Copy link
Collaborator

mattsse commented Aug 11, 2023

let's do it!

@DaniPopes DaniPopes merged commit 9a92217 into gakonst:master Aug 12, 2023
19 checks passed
@DaniPopes DaniPopes deleted the opt-sol-dirty branch August 12, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants