Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rlp decode deposit tx #2616

Merged
merged 3 commits into from
Sep 27, 2023
Merged

fix: rlp decode deposit tx #2616

merged 3 commits into from
Sep 27, 2023

Conversation

merklefruit
Copy link
Contributor

mattsse
mattsse approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct, do we have some samples for tests?

@merklefruit
Copy link
Contributor Author

merklefruit commented Sep 26, 2023 •
edited
Loading

looks correct, do we have some samples for tests?

Added a test that does the following:

  1. decoded tx -> rlp bytes
  2. rlp bytes -> decoded tx

Also fixed a bug with the signature for deposit txs

mattsse
mattsse approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pending @DaniPopes

@DaniPopes DaniPopes merged commit eb29df1 into gakonst:master Sep 27, 2023
19 checks passed
@merklefruit merklefruit deleted the decode-base-deposit branch September 27, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimism (0x7e) transaction is not RLP decoded
3 participants
@merklefruit @mattsse @DaniPopes