remove arbitrary precision feature #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
approved these changes
Sep 28, 2023
|
fixing clippy rn |
|
I know now why this was added... geth emits large ints for |
|
@Rjected should we remove the totaldifficulty from the object? |
We probably can, IIRC this is not required for spawning geth with a normal genesis, and we don't use ethers for hive tests / hive genesis |
mattsse
force-pushed
the
matt/rm-arbitrary-precision
branch
from
337b7eb
to
747bbe8
Compare
|
@Rjected turns out this can be fixed by manually converting the captured float, let's do that on reth as well |
mattsse
force-pushed
the
matt/rm-arbitrary-precision
branch
from
3328fdd
to
c9d68be
Compare
mattsse
force-pushed
the
matt/rm-arbitrary-precision
branch
from
c9d68be
to
7bac093
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2206
this feature is kinda horrible and we should not force anyone into using it.
this is also only useful when deserializing json large numbers but since u256 are supposed to be hex it's fine to not support deserializing arbitrary numbers