Apply WebSocketConfig to initial WS provider connection #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… uses passed in config
svenski123
force-pushed
the
231107-fix-connect-with-config
branch
from
46f7fdc
to
88fa4a9
Compare
|
Rebased/force pushed on top of 0543e1c which addressed the failed clippy and fmt checks in other parts of the code unrelated to this PR. |
|
I bumped the solc version from v0.8.22 to v0.8.23 in the test case in ethers-solc/src/compile/mod.rs. |
mattsse
approved these changes
Nov 13, 2023
| @@ -291,7 +310,7 @@ impl RequestManager { | |||
| reconnects: usize, | |||
| ) -> Result<(Self, WsClient), WsClientError> { | |||
| let (backend, (instructions_tx, instructions_rx), channel_map) = | |||
| Self::connect_internal(conn.clone()).await?; | |||
| Self::connect_with_config_internal(conn.clone(), config.clone()).await?; | |||
There was a problem hiding this comment.
ah I see, we didn't use the config for the connect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WsClient::connect_with_config() et al. ignores the passed in WebSocketConfig object on the initial connection.
On subsequent reconnections the WebSocketConfig object (as saved by the RequestManager) is correctly applied to the backend.
This is used to among other things increase the maximum allowable frame size (i.e. >16MB) or message size.