feat: substitute overloaded functions #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
force-pushed
the
matt/support-overloaded-functions
branch
from
13f8f66
to
3aa7b66
Compare
gakonst
approved these changes
Oct 13, 2021
Comment on lines
+114
to
+115
| let _ethers_core = util::ethers_core_crate(); | ||
| let _ethers_providers = util::ethers_providers_crate(); |
There was a problem hiding this comment.
oh, seems like they're unused, clippy --fix must have detected that,
can be removed
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
* fix(foundryup): warn macos users without libusb * fix(forgeup): check for libusb file directly * Update foundryup/install Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #238
Solution
In case of overloaded functions we would follow rust's general convention of suffixing the function name with _with
The first function or the function with the least amount of arguments should be named as in the ABI, the following functions suffixed with with + additional_params[0].name + (and(additional_params[1+i].name))*
PR Checklist