fix(codec)!: ambiguity unit8[] and bytes #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
requested changes
Nov 24, 2021
| @@ -117,7 +117,7 @@ macro_rules! impl_abi_type { | |||
| } | |||
|
|
|||
| impl_abi_type!( | |||
| Vec<u8> => Bytes, | |||
| Vec<u8> => Array(Box::new(ParamType::Uint(8))), | |||
There was a problem hiding this comment.
I think this won't work, because bytes memory which translates to Vec<u8> will now be translate to Array(Uint(8)) as a uint8[].
Could we make bytes memory translate to ethers::core::Bytes?
(I think that's probably the bug here, given the tests' output)
mattsse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Vec<u8>since it was used forbytesandunit8[]alike.Solution
bytesisethers::types::Bytesandunit8[]isVec<u8>This is a breaking change but can we fixed easily with
into()conventionsPR Checklist