Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configure rustls & openssl via feature flag #703

Merged
merged 11 commits into from
Dec 19, 2021
Merged

Conversation

gakonst
Copy link
Owner

@gakonst gakonst commented Dec 17, 2021

Some downstream foundry users (foundry-rs/foundry#229) are experiencing issues installing on different platforms. I suspect it MIGHT be related to the openssl dependency which was being pulled in by reqwest.

We can maybe resolve it by feature gating reqwest's SSL provider everywhere, and importing ethers with the reqwest/rustls backend.

Depends on alloy-rs/svm-rs#11

Also, once seanmonstar/reqwest#1396 is released we should bump reqwest to de-duplicate our certs deps


So this seems to address the issues around

  1. openssl being pulled in
  2. sha2 being pulled in

Open problems:

@gakonst gakonst changed the title fix: trim deps fix: configure rustls & openssl via feature flag Dec 17, 2021
@gakonst gakonst merged commit d7c29cc into master Dec 19, 2021
@gakonst gakonst deleted the fix/trim-deps branch December 19, 2021 14:56
meetmangukiya pushed a commit to meetmangukiya/ethers-rs that referenced this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant