Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace anyhow with eyre #858

Merged
merged 6 commits into from
Feb 2, 2022
Merged

refactor: replace anyhow with eyre #858

merged 6 commits into from
Feb 2, 2022

Conversation

prestwich
Copy link
Collaborator

Motivation

As foundry is using eyre, we should transition more crates to use it instead of anyhow

Solution

Move the contract abigen crate to eyre

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

ethers-contract/ethers-contract-abigen/src/contract.rs Outdated Show resolved Hide resolved
@prestwich
Copy link
Collaborator Author

cool, I just reviewed all eyre uses in the lib and made them more idiomatic with bail! and ensure! whereever possible

Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

@gakonst gakonst merged commit 7e4e8e2 into master Feb 2, 2022
@gakonst gakonst deleted the prestwich/abigen-eyre branch February 2, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants