-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ktx2 loader #1625
Support ktx2 loader #1625
Conversation
|
packages/loader/src/ktx2/BinomialLLCTranscoder/BinomialLLCTranscoder.ts
Outdated
Show resolved
Hide resolved
[KTX2TargetFormat.ETC]: [GLCapabilityType.etc], | ||
[KTX2TargetFormat.DXT]: [GLCapabilityType.s3tc], | ||
[KTX2TargetFormat.PVRTC]: [GLCapabilityType.pvrtc, GLCapabilityType.pvrtc_webkit] | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
canIUse
should improve
const formatPriorities = item.params?.formatPriorities; | ||
const targetFormat = KTX2Loader._detectTranscoder(resourceManager.engine, ktx2Container, formatPriorities); | ||
let transcodeResultPromise: Promise<any>; | ||
if (targetFormat === KTX2TargetFormat.ASTC && ktx2Container.isUASTC) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
R8
RG8
RGBA8
should use KhronosTranscoder
too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait engine support
packages/loader/src/ktx2/KhronosTranscoder/TranscoderWorkerCode.ts
Outdated
Show resolved
Hide resolved
packages/loader/src/ktx2/KhronosTranscoder/KhronosTranscoder.ts
Outdated
Show resolved
Hide resolved
packages/loader/src/ktx2/KhronosTranscoder/KhronosTranscoder.ts
Outdated
Show resolved
Hide resolved
* dev/1.1: Support ktx2 loader (galacean#1625) feat: add texture plugin to support ktx loader (galacean#1640) Fix blend shape bug due to buffer index errors (galacean#1632) Model Mesh supports two-way data synchronization (galacean#1588)
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Support ktx2 loader
Usage
Basic
Init Transcode WebWorker
Destroy Transcode WebWorker
Specify Format Priority(Advanced)