Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blend shape bug due to buffer index errors #1632

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

No description provided.

@cptbtptpbcptdtptp cptbtptpbcptdtptp changed the title Fix the bugindex of buffer in blend shape is wrong. Fix the index of buffer in blend shape is wrong. Jul 4, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp changed the title Fix the index of buffer in blend shape is wrong. Fix the index of buffer in blend shape is wrong. Jul 4, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp added the bug Something isn't working label Jul 4, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this Jul 4, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp added this to the 1.1 milestone Jul 4, 2023
Copy link
Member

@GuoLei1990 GuoLei1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not consider setVertexElements()

@GuoLei1990 GuoLei1990 changed the title Fix the index of buffer in blend shape is wrong. Fix blend shape bug caused by the error of buffer index Jul 5, 2023
@GuoLei1990 GuoLei1990 changed the title Fix blend shape bug caused by the error of buffer index Fix blend shape bug due to buffer index errors Jul 5, 2023
@GuoLei1990 GuoLei1990 merged commit 0f9ed26 into galacean:dev/1.1 Jul 5, 2023
5 checks passed
GuoLei1990 added a commit to Sway007/engine that referenced this pull request Jul 16, 2023
* dev/1.1:
  Support ktx2 loader (galacean#1625)
  feat: add texture plugin to support ktx loader (galacean#1640)
  Fix blend shape bug due to buffer index errors (galacean#1632)
  Model Mesh supports two-way data synchronization (galacean#1588)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants