glTF support basisu #1662
Merged
glTF support basisu #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuxudong
reviewed
Jul 25, 2023
| BufferUsage.Static, | ||
| keepMeshData | ||
| ); | ||
| vertexBuffer.setData(vertices); |
| @@ -91,6 +92,7 @@ export class GLTFMeshParser extends GLTFParser { | |||
| let vertexBuffer = accessorBuffer.vertexBuffer; | |||
| if (!vertexBuffer) { | |||
| vertexBuffer = new Buffer(engine, BufferBindFlag.VertexBuffer, vertices, BufferUsage.Static, keepMeshData); | |||
| accessorBuffer.vertexBuffer = vertexBuffer; | |||
GuoLei1990
reviewed
Jul 28, 2023
GuoLei1990
approved these changes
Jul 31, 2023
zhuxudong
approved these changes
Jul 31, 2023
GuoLei1990
added a commit
to GuoLei1990/galacean-engine
that referenced
this pull request
Aug 2, 2023
* dev/1.1: (48 commits) fix: skin mesh error (galacean#1675) fix: test error (galacean#1674) test: fix github test (galacean#1669) test: fix ci not work (galacean#1670) glTF support basisu (galacean#1662) fix: `EventDispatcher` static pool bug fix: eventdispatcher bug (galacean#1671) fix: animation event bug (galacean#1666) Shader pass support blend (galacean#1668) Fix model mesh advanced data write bug (galacean#1663) Cherry pick glTF conflict (galacean#1660) Fix worker status set error and can't throw error bug (galacean#1652) Fix parse glTF texture wrap & filterMode bug (galacean#1659) Add shader lab package and support shader framework (galacean#1610) Fix text wrap bug (galacean#1644) chore: use strict error msg and type (galacean#1647) Fix text error for set text to "" and set enableWrapping to true (galacean#1634) "v1.0.0-beta.17" Process GLTFBufferParser and GLTFTextureParser pipelines in parallel (galacean#1638) Fix animation clip loader, clip change promise to assetPromise, controller json parse (galacean#1506) ...
GuoLei1990
added a commit
to GuoLei1990/galacean-engine
that referenced
this pull request
Aug 3, 2023
* dev/1.1: (43 commits) fix: skin mesh error (galacean#1675) fix: test error (galacean#1674) test: fix github test (galacean#1669) test: fix ci not work (galacean#1670) glTF support basisu (galacean#1662) fix: `EventDispatcher` static pool bug fix: eventdispatcher bug (galacean#1671) fix: animation event bug (galacean#1666) Fix parse glTF texture wrap & filterMode bug (galacean#1659) Fix text wrap bug (galacean#1644) chore: use strict error msg and type (galacean#1647) Fix text error for set text to "" and set enableWrapping to true (galacean#1634) "v1.0.0-beta.17" Process GLTFBufferParser and GLTFTextureParser pipelines in parallel (galacean#1638) Fix animation clip loader, clip change promise to assetPromise, controller json parse (galacean#1506) fix: the layer is not cloned when the node is cloned (galacean#1636) Fix glTF texture mipmap bug (galacean#1637) "v1.0.0-beta.16" Adjust main light to directional lights first (galacean#1635) Fix `AmbientLight` can't destroy bug (galacean#1633) ...
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements