Fix multi scene script error and GC problem #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for (let i = scripts.length - 1; i >= 0; --i) { | ||
| const script = scripts.get(i); | ||
| script._waitHandlingInValid || script.onBeginRender(camera); | ||
| script?.onBeginRender(camera); |
There was a problem hiding this comment.
scripts.get(i)?.onBeginRender(camera);
* dev/1.1: fix: glTF parser error and test case (galacean#1723) # Conflicts: # tests/src/loader/GLTFLoader.test.ts
3 tasks
GuoLei1990
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev/1.1 #1724 +/- ##
===========================================
+ Coverage 61.37% 61.46% +0.08%
===========================================
Files 410 430 +20
Lines 21834 22541 +707
Branches 3140 3201 +61
===========================================
+ Hits 13401 13854 +453
- Misses 7244 7471 +227
- Partials 1189 1216 +27
☔ View full report in Codecov by Sentry. |
GuoLei1990
added a commit
to GuoLei1990/galacean-engine
that referenced
this pull request
Sep 2, 2023
* dev/1.1: Fix delay add scene can't fire `onEnbaleInScene` bug (galacean#1725) Fix multi scene script error and GC problem (galacean#1724) fix: glTF parser error and test case (galacean#1723) fix: Script onDisable error (galacean#1719) "v1.1.0-alpha.2" Add physic unit test timeout (galacean#1717) "v1.0.0-beta.20" Fix `PhysicManager` fixedTimeStep less than 0 bug (galacean#1715) Fix physx unit test (galacean#1714) Fix a series of physical system problems (galacean#1712) Fix avoid destroyed material error (galacean#1705) # Conflicts: # packages/core/package.json # packages/design/package.json # packages/draco/package.json # packages/galacean/package.json # packages/loader/package.json # packages/math/package.json # packages/physics-lite/package.json # packages/physics-physx/package.json # packages/rhi-webgl/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements