Skip to content

Fix a series of physical system problems#1712

Merged
GuoLei1990 merged 8 commits intogalacean:mainfrom
luzhuang:fix/physxCollision
Aug 28, 2023
Merged

Fix a series of physical system problems#1712
GuoLei1990 merged 8 commits intogalacean:mainfrom
luzhuang:fix/physxCollision

Conversation

@luzhuang
Copy link
Copy Markdown
Contributor

@luzhuang luzhuang commented Aug 24, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Fixed: onCollisionEnter can not be triggered
  • Fixed: An issue where kinematic collision detection failed
  • Fixed: Collider setPosition error
  • Fixed: The Lite Physics rayCast error when distance is lower than hit distance

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@luzhuang luzhuang added the bug Something isn't working label Aug 24, 2023
@luzhuang luzhuang requested a review from GuoLei1990 August 24, 2023 03:32
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 22.22% and project coverage change: -0.05% ⚠️

Comparison is base (3d6bd03) 59.31% compared to head (771ab2f) 59.26%.

❗ Current head 771ab2f differs from pull request most recent head 20d9998. Consider uploading reports for the commit 20d9998 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1712      +/-   ##
==========================================
- Coverage   59.31%   59.26%   -0.05%     
==========================================
  Files         368      368              
  Lines       19328    19327       -1     
  Branches     2803     2802       -1     
==========================================
- Hits        11465    11455      -10     
- Misses       6786     6794       +8     
- Partials     1077     1078       +1     
Files Changed Coverage Δ
.../physics-lite/src/shape/LiteSphereColliderShape.ts 21.05% <0.00%> (ø)
packages/physics-lite/src/LitePhysicsManager.ts 26.82% <25.00%> (+0.16%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luzhuang luzhuang changed the title Fix/physx collision Fix onCollisionEnter can not be triggered Aug 24, 2023
@luzhuang luzhuang changed the title Fix onCollisionEnter can not be triggered Fix onCollisionEnter can not be triggered and failure of kinematic collision detection Aug 24, 2023
@luzhuang luzhuang changed the title Fix onCollisionEnter can not be triggered and failure of kinematic collision detection Fix a series of physical system problems Aug 25, 2023
Copy link
Copy Markdown
Member

@GuoLei1990 GuoLei1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add unit test

@GuoLei1990 GuoLei1990 added the physics Engine's physical system label Aug 25, 2023
@luzhuang luzhuang force-pushed the fix/physxCollision branch from 8cc9f4f to 20d9998 Compare August 28, 2023 09:21
@GuoLei1990 GuoLei1990 merged commit 2a788ca into galacean:main Aug 28, 2023
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Aug 30, 2023
* main:
  Add physic unit test timeout (galacean#1717)
  "v1.0.0-beta.20"
  Fix `PhysicManager`  fixedTimeStep less than 0 bug (galacean#1715)
  Fix physx unit test (galacean#1714)
  Fix a series of physical system problems (galacean#1712)
  Fix avoid destroyed material error (galacean#1705)
  "v1.0.0-beta.19"

# Conflicts:
#	packages/core/package.json
#	packages/core/src/physics/PhysicsScene.ts
#	packages/design/package.json
#	packages/draco/package.json
#	packages/galacean/package.json
#	packages/loader/package.json
#	packages/math/package.json
#	packages/physics-lite/package.json
#	packages/physics-lite/src/LitePhysicsManager.ts
#	packages/physics-physx/package.json
#	packages/physics-physx/src/PhysXPhysics.ts
#	packages/rhi-webgl/package.json
#	tests/package.json
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Sep 2, 2023
* dev/1.1:
  Fix delay add scene can't fire `onEnbaleInScene` bug (galacean#1725)
  Fix multi scene script error and GC problem (galacean#1724)
  fix: glTF parser error and test case (galacean#1723)
  fix: Script onDisable error (galacean#1719)
  "v1.1.0-alpha.2"
  Add physic unit test timeout (galacean#1717)
  "v1.0.0-beta.20"
  Fix `PhysicManager`  fixedTimeStep less than 0 bug (galacean#1715)
  Fix physx unit test (galacean#1714)
  Fix a series of physical system problems (galacean#1712)
  Fix avoid destroyed material error (galacean#1705)

# Conflicts:
#	packages/core/package.json
#	packages/design/package.json
#	packages/draco/package.json
#	packages/galacean/package.json
#	packages/loader/package.json
#	packages/math/package.json
#	packages/physics-lite/package.json
#	packages/physics-physx/package.json
#	packages/rhi-webgl/package.json
GuoLei1990 added a commit to cptbtptpbcptdtptp/engine that referenced this pull request Sep 11, 2023
* main: (23 commits)
  Fix the boundary value of exitTime issue with crossFade (galacean#1695)
  test(Light): add unit test case of `Light` (galacean#1702)
  Add unit test case of `BlendShapeManager` (galacean#1704)
  test(BlendShape): add unit test case of BlendShape (galacean#1703)
  Fixed an issue where animation playback skipped the first frame (galacean#1734)
  Fix the bug when user change speed direction in event handler (galacean#1692)
  test(PrimitiveMesh): update unit test case of `PrimitiveMesh` (galacean#1684)
  test(BufferMesh): update unit test case of (galacean#1691)
  test(SkinnedMeshRenderer): update unit test case of `SkinnedMeshRenderer` (galacean#1690)
  test(MeshRenderer): update unit test case of `MeshRenderer` (galacean#1683)
  chore: fix scene loader (galacean#1711)
  Fix shader compatible issue (galacean#1718)
  Add physic unit test timeout (galacean#1717)
  "v1.0.0-beta.20"
  Fix `PhysicManager`  fixedTimeStep less than 0 bug (galacean#1715)
  Fix physx unit test (galacean#1714)
  Fix a series of physical system problems (galacean#1712)
  Fix avoid destroyed material error (galacean#1705)
  "v1.0.0-beta.19"
  fix: memory leak of Transform (galacean#1701)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working physics Engine's physical system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants