Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SpriteMask.sprite to null after destroying the sprite. #1866

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

No description provided.

@cptbtptpbcptdtptp cptbtptpbcptdtptp added bug Something isn't working sprite 2D Sprite labels Nov 6, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (7a7bc45) 67.01% compared to head (d775679) 67.03%.
Report is 1 commits behind head on main.

❗ Current head d775679 differs from pull request most recent head f38da28. Consider uploading reports for the commit f38da28 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1866      +/-   ##
==========================================
+ Coverage   67.01%   67.03%   +0.02%     
==========================================
  Files         471      471              
  Lines       23742    23751       +9     
  Branches     3381     3382       +1     
==========================================
+ Hits        15911    15922      +11     
- Misses       6633     6634       +1     
+ Partials     1198     1195       -3     
Files Coverage Δ
packages/core/src/2d/sprite/SpriteMask.ts 87.61% <100.00%> (+0.22%) ⬆️
...e-deserialize/resources/parser/ReflectionParser.ts 10.95% <0.00%> (-1.17%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 merged commit 18c7570 into galacean:main Nov 8, 2023
5 checks passed
GuoLei1990 added a commit that referenced this pull request Nov 13, 2023
* main:
  fix: material destroy bug (#1864)
  Fix asset promise (#1867)
  Set `SpriteMask.sprite` to null after destroying the sprite.  (#1866)
  "v1.1.0-beta.19"
  Add recursive class and methods (#1865)
  Fix url clamp bug (#1860)
  feat: add recursive object parse (#1863)
  Fix ShaderLab compatible with no varying variable (#1859)
  Fix ShaderLab umd package compilation and circle reference (#1856)
  Add unit test case of `ColliderShape` (#1740)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sprite 2D Sprite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants