Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recursive class and methods #1865

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

gz65555
Copy link
Collaborator

@gz65555 gz65555 commented Nov 6, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (7a7bc45) 67.01% compared to head (cc26ac9) 67.00%.

❗ Current head cc26ac9 differs from pull request most recent head a616143. Consider uploading reports for the commit a616143 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1865      +/-   ##
==========================================
- Coverage   67.01%   67.00%   -0.01%     
==========================================
  Files         471      471              
  Lines       23742    23751       +9     
  Branches     3381     3382       +1     
==========================================
+ Hits        15911    15915       +4     
- Misses       6633     6638       +5     
  Partials     1198     1198              
Files Coverage Δ
...e-deserialize/resources/parser/ReflectionParser.ts 10.66% <0.00%> (-1.46%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 added the ignore for release ignore for release label Nov 6, 2023
@GuoLei1990 GuoLei1990 merged commit 1cd2a56 into galacean:main Nov 6, 2023
5 checks passed
GuoLei1990 added a commit that referenced this pull request Nov 13, 2023
* main:
  fix: material destroy bug (#1864)
  Fix asset promise (#1867)
  Set `SpriteMask.sprite` to null after destroying the sprite.  (#1866)
  "v1.1.0-beta.19"
  Add recursive class and methods (#1865)
  Fix url clamp bug (#1860)
  feat: add recursive object parse (#1863)
  Fix ShaderLab compatible with no varying variable (#1859)
  Fix ShaderLab umd package compilation and circle reference (#1856)
  Add unit test case of `ColliderShape` (#1740)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release ignore for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants