Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove common runtime #609

Merged
merged 7 commits into from
Jul 1, 2023
Merged

refactor: remove common runtime #609

merged 7 commits into from
Jul 1, 2023

Conversation

Roznovjak
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 11, 2023

Crate versions that have been updated:

  • runtime-integration-tests: v1.7.16 -> v1.7.17
  • hydradx: v10.0.0 -> v10.0.1
  • primitives: v5.7.3 -> v5.8.0
  • hydradx-runtime: v162.0.0 -> v163.0.0

Runtime version has been increased.

@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Patch coverage: 53.90% and no project coverage change.

Comparison is base (35c131b) 64.66% compared to head (9cbbee5) 64.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #609   +/-   ##
=======================================
  Coverage   64.66%   64.67%           
=======================================
  Files         130      132    +2     
  Lines        9459     9458    -1     
=======================================
  Hits         6117     6117           
+ Misses       3342     3341    -1     
Impacted Files Coverage Δ
node/src/chain_spec/mod.rs 0.00% <ø> (ø)
node/src/service.rs 0.00% <ø> (ø)
runtime/hydradx/src/adapters.rs 78.37% <ø> (ø)
runtime/hydradx/src/benchmarking/currencies.rs 100.00% <ø> (ø)
runtime/hydradx/src/benchmarking/duster.rs 100.00% <ø> (ø)
runtime/hydradx/src/benchmarking/omnipool.rs 100.00% <ø> (ø)
runtime/hydradx/src/benchmarking/vesting.rs 100.00% <ø> (ø)
runtime/hydradx/src/weights/balances.rs 14.28% <ø> (ø)
runtime/hydradx/src/weights/circuit_breaker.rs 71.42% <ø> (ø)
runtime/hydradx/src/weights/claims.rs 0.00% <ø> (ø)
... and 32 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@apopiak apopiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, not a huge fan of splitting the runtime/lib.rs (because I like doing ctrl+F in the file 😅 ), but might be sensible

primitives/Cargo.toml Outdated Show resolved Hide resolved
primitives/Cargo.toml Outdated Show resolved Hide resolved
@mrq1911 mrq1911 merged commit 6240b97 into master Jul 1, 2023
8 checks passed
@Roznovjak Roznovjak deleted the remove_common_runtime branch July 1, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants