Fix a deadlock associated with thread safe IO #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… safe IO locks This is useful for debugging deadlocks.
The numerical root finder code can be called recursively which lead to deadlocks in thread safe IO critical sections. This is now avoided by not doing function evaluations directly inside a `write` statement. Additionally, warning messages are not generated/output if the optional `status` parameter is present - this could have resulted in huge warning logs being produced.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The numerical root finder code can be called recursively which lead to deadlocks in thread safe IO critical sections. This is now avoided by not doing function evaluations directly inside a
writestatement. Additionally, warning messages are not generated/output if the optionalstatusparameter is present - this could have resulted in huge warning logs being produced.Also adds reporting on reporting on acquisition/release of thread safe IO locks. This is useful for debugging deadlocks.