Update to 1.16 #32
Merged
Update to 1.16 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexylena
reviewed
Jul 19, 2021
| @@ -1,6 +1,6 @@ | |||
| import click | |||
| from parsec.cli import pass_context, json_loads | |||
| from parsec.decorators import custom_exception, list_output | |||
| from parsec.decorators import custom_exception, dict_output | |||
There was a problem hiding this comment.
hmm, this looks wrong, I wonder what happened here.
it's definitely list[dict]
https://bioblend.readthedocs.io/en/latest/api_docs/galaxy/all.html?highlight=get_datasets#bioblend.galaxy.datasets.DatasetClient.get_datasets
|
Thanks for doing this @simonbray! This looks good overall, but clearly need to figure out what went wrong with the output type detection. I'll look into it. |
hexylena
approved these changes
Aug 31, 2021
|
Fantastic. Thanks for doing the update @simonbray! |
|
It's live. Also migrated it to github actions since travis is travis. |
|
Nice. Thanks a lot @hexylena! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autobuilder script made a few strange changes, especially adding a lot of
module.pyfiles, which I reverted. Overall it was a very smooth process though.