Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tools and updates of old tools not creatd / updated in TS #36

Open
yvanlebras opened this issue Nov 11, 2020 · 4 comments
Open

New tools and updates of old tools not creatd / updated in TS #36

yvanlebras opened this issue Nov 11, 2020 · 4 comments

Comments

@yvanlebras
Copy link
Contributor

It appears tools are not created or updated in the ecology section of main toolshed tools. Any idea @bgruening ?

Will try to look at gh actions reports as it seems that info has to be there ;)

@yvanlebras
Copy link
Contributor Author

As an example, here https://github.com/galaxyecology/tools-ecology/actions/runs/353307623 is a failed action workflow, when we can see a message I am not sure to understand:

Check failure on line 1 in .github
@github-actions github-actions / Lint R scripts (4.0.1)

.github#L1

Process completed with exit code 1.

Looking at the report, it seems ""just"" lintr is failing, but if I am not wrong, this is not mandatory that lintr success no?

@bgruening
Copy link
Collaborator

You see here the failures: https://github.com/galaxyecology/tools-ecology/actions

@bgruening
Copy link
Collaborator

And it turns out that the deploy step only applies when the linting (Rlint) also is green. https://github.com/galaxyecology/tools-ecology/blob/master/.github/workflows/pr.yaml#L382

Do you want to change that? Or fix the linting?

@yvanlebras
Copy link
Contributor Author

Ok, thank you for your rapid answer. We will look at both solutions with Coline and if needed, I come back to you. Whishing you a good day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants