Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template out shed tool conf more better #80

Merged
merged 2 commits into from
Jul 16, 2019
Merged

Template out shed tool conf more better #80

merged 2 commits into from
Jul 16, 2019

Conversation

hexylena
Copy link
Member

@hexylena hexylena commented Jul 5, 2019

xref galaxyproject/training-material#1445

does this look ok? untested because internet.

@hexylena hexylena requested a review from natefoo July 5, 2019 12:41
@natefoo
Copy link
Member

natefoo commented Jul 7, 2019

I think this would overwrite shed_tool_conf.xml after Galaxy writes to it?

@hexylena
Copy link
Member Author

@natefoo addressed with force: no

natefoo
natefoo approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@natefoo natefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find with force: no!

@natefoo natefoo merged commit 1abff7c into master Jul 16, 2019
@hexylena hexylena deleted the shed-template branch July 19, 2022 14:55
@guerler guerler mentioned this pull request Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natefoo natefoo natefoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hexylena @natefoo