Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deconstruct client build process #85

Merged
merged 6 commits into from
Oct 3, 2019
Merged

Conversation

natefoo
Copy link
Member

@natefoo natefoo commented Sep 27, 2019

This adds some transparency for the admin but requires us to synchronize with the client build scripts and will be complicated by differences across versions. Because of that, the default is still to invoke make client-production-maps.

@natefoo natefoo requested a review from dannon September 27, 2019 19:28
@dannon
Copy link
Member

dannon commented Oct 2, 2019

If you did want to separate the (new, and likely growing) plugin building/staging from the other gulp stuff that's central to the actual client build you could break it down like this:

yarn run gulp fonts && yarn run gulp stageLibs
yarn run gulp plugins

Default does all of that, and for simplicity the 'plugins' one is lumped into the same process, but I wasn't sure if you'd want to separate those concerns a little more in this decomposition. Doesn't matter to me.

edit: Just submitted galaxyproject/galaxy#8742 after reviewing the targets and thinking about it a bit in this context. You'll want to take that into account I guess.

@natefoo
Copy link
Member Author

natefoo commented Oct 3, 2019

Thanks for the review and suggestions!

@natefoo natefoo merged commit 29b7a2b into master Oct 3, 2019
@hexylena hexylena deleted the client-build-deconstruction branch February 14, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants