Client build process refinement #8742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gins', and of course the default that does everything.
…are used to build these plugins.
dannon
added
kind/refactoring
|
@natefoo Do we have a good way to coordinate these targets being implemented when the next test/whatever rollout happens, relative the older 3 targeted in galaxyproject/ansible-galaxy#85? |
|
Implemented in Ansible you mean? I added version detection there a bit ago for the node version stuff so we should be able to add conditionals for this. |
|
@natefoo Yeah, exactly. When we go to deploy the next rev that contains this code the items (https://github.com/galaxyproject/ansible-galaxy/pull/85/files#diff-7e1ee3914098357abbc81ad7a8d7eacaR15) will just be 'plugins' and 'client'. |
|
Thanks, I created an issue for it in galaxyproject/ansible-galaxy#88. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks gulp build targets to be more sensible and clear. This came about looking at the client build process deconstruction issue referenced below; more clear separation of concerns in the gulp tasks.
Drops targets from primary client package that should not be used anymore (we've moved the building of these to the individual packages).