Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-Authored-By: Nate Coraor <nate@bx.psu.edu>
  • Loading branch information
hexylena and natefoo committed Feb 27, 2020
1 parent bfd8883 commit 1e9baa0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ the `pip_virtualenv_command` variable.
Breaking Changes
----------------

As of 1.0.0, installation with git+pip, and from source, are no longer supported.
As of 1.0.0, installation directly from source using `git clone` is no longer supported. However, `pulsar_package_name` and `pulsar_package_version` can be used to install using pip's `git+https` method.

Role Variables
--------------
Expand Down
2 changes: 1 addition & 1 deletion tasks/virtualenv.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
- name: Install Pulsar
pip:
name: "{{ pulsar_package_name }}"
vesion: "{{ pulsar_package_version | default(omit) }}"
version: "{{ pulsar_package_version | default(omit) }}"
state: latest
virtualenv: "{{ pulsar_venv_dir }}"
extra_args: "{{ pip_extra_args | default('') }}"
Expand Down

0 comments on commit 1e9baa0

Please sign in to comment.