Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Done: Refactor shedtools #104

Merged
merged 79 commits into from Aug 6, 2018
Merged

Done: Refactor shedtools #104

merged 79 commits into from Aug 6, 2018

Commits on Jul 18, 2018

  1. rename shed_tools

    @rhpvorderman
    rhpvorderman committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    01ddcce View commit details
    Browse the repository at this point in the history

  2. start from scratch

    @rhpvorderman
    rhpvorderman committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    45c40e1 View commit details
    Browse the repository at this point in the history

  3. include docstring

    @rhpvorderman
    rhpvorderman committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    c2e486d View commit details
    Browse the repository at this point in the history

  4. start with general layout for class

    @rhpvorderman
    rhpvorderman committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    7783b7f View commit details
    Browse the repository at this point in the history

  5. move args parser elsewhere

    @rhpvorderman
    rhpvorderman committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    347efc3 View commit details
    Browse the repository at this point in the history

  6. rationalize main function

    @rhpvorderman
    rhpvorderman committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    d6c8fde View commit details
    Browse the repository at this point in the history

  7. add log stuff to keep backwards compatibility

    @rhpvorderman
    rhpvorderman committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    9e50cf7 View commit details
    Browse the repository at this point in the history

  8. start implementing install tools method

    @rhpvorderman
    rhpvorderman committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    f089f11 View commit details
    Browse the repository at this point in the history

  9. add functionality to not flatten revisions

    @rhpvorderman
    rhpvorderman committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    045be02 View commit details
    Browse the repository at this point in the history

  10. add code to checkout if something is already installed

    @rhpvorderman
    rhpvorderman committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    8cabf79 View commit details
    Browse the repository at this point in the history

  11. add flatten repo info method

    @rhpvorderman
    rhpvorderman committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    687122d View commit details
    Browse the repository at this point in the history

  12. optimize the same repository

    @rhpvorderman
    rhpvorderman committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    596f4c1 View commit details
    Browse the repository at this point in the history

  13. wip

    @rhpvorderman
    rhpvorderman committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    4dbaa19 View commit details
    Browse the repository at this point in the history

  14. wip

    @rhpvorderman
    rhpvorderman committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    1d57d66 View commit details
    Browse the repository at this point in the history

  15. further refactoring

    @rhpvorderman
    rhpvorderman committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    6c20ba6 View commit details
    Browse the repository at this point in the history

  16. rewrite wait for install function

    @rhpvorderman
    rhpvorderman committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    5b53916 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2018

  1. complete install function

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    5ee185b View commit details
    Browse the repository at this point in the history

  2. refactor logging

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    9c832e8 View commit details
    Browse the repository at this point in the history

  3. combat bugs

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    60f9a44 View commit details
    Browse the repository at this point in the history

  4. implement update method

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    393c03a View commit details
    Browse the repository at this point in the history

  5. insert test methodology

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    9b8b3fa View commit details
    Browse the repository at this point in the history

  6. added test code

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    2e61378 View commit details
    Browse the repository at this point in the history

  7. start updating the main file

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    5842662 View commit details
    Browse the repository at this point in the history

  8. proper error handling when getting galaxy connection

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    e3938c5 View commit details
    Browse the repository at this point in the history

  9. update main logic to reflect installation procedure

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    8ec0f30 View commit details
    Browse the repository at this point in the history

  10. remove useless update_tools variable

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    d8e7fe5 View commit details
    Browse the repository at this point in the history

  11. do some reshuffling of the arg parser

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    aaf74e3 View commit details
    Browse the repository at this point in the history

  12. bye bye spaghetti code!

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    1213f4e View commit details
    Browse the repository at this point in the history

  13. fix linting issues and add a few comments

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    29238bd View commit details
    Browse the repository at this point in the history

  14. fix parser issue

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    33f5a83 View commit details
    Browse the repository at this point in the history

  15. fix issue with latest command

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    9f17713 View commit details
    Browse the repository at this point in the history

  16. fix kwargs

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    4d05e78 View commit details
    Browse the repository at this point in the history

  17. fix error in get-tool-list

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    4cbf527 View commit details
    Browse the repository at this point in the history

  18. move general method outside of class

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    c6b2677 View commit details
    Browse the repository at this point in the history

  19. readd property things

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    0688db3 View commit details
    Browse the repository at this point in the history

  20. fix small mistake

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    579c817 View commit details
    Browse the repository at this point in the history

  21. fix semantic error

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    9e3cb0e View commit details
    Browse the repository at this point in the history

  22. fix missing quotes

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    f5dbabd View commit details
    Browse the repository at this point in the history

  23. fixed get-tool-list issue

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    dd6b8a7 View commit details
    Browse the repository at this point in the history

  24. remove print statements

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    21a398d View commit details
    Browse the repository at this point in the history

  25. fix changeset_revision error

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    c2e24ff View commit details
    Browse the repository at this point in the history

  26. small typo fix

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    292c658 View commit details
    Browse the repository at this point in the history

  27. fix some defaults

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    48773f3 View commit details
    Browse the repository at this point in the history

  28. prevent assignment of literal none

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    51577f6 View commit details
    Browse the repository at this point in the history

  29. fix codacy issues

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    50c13f9 View commit details
    Browse the repository at this point in the history

  30. calculate total length over number of installable revisions

    @rhpvorderman
    rhpvorderman committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    aab8b6e View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2018

  1. update test

    @rhpvorderman
    rhpvorderman committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    24f4145 View commit details
    Browse the repository at this point in the history

  2. add extra function to get-tool-list

    @rhpvorderman
    rhpvorderman committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    293cbd6 View commit details
    Browse the repository at this point in the history

  3. solve aliasing problem

    @rhpvorderman
    rhpvorderman committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    9a86ea2 View commit details
    Browse the repository at this point in the history

  4. pin data_manager to stable revision

    @rhpvorderman
    rhpvorderman committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    e316e78 View commit details
    Browse the repository at this point in the history

  5. remove error

    @rhpvorderman
    rhpvorderman committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    2d75fea View commit details
    Browse the repository at this point in the history

  6. use toolshed client to determine already installed repos

    @rhpvorderman
    rhpvorderman committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    c97e43c View commit details
    Browse the repository at this point in the history

  7. enable get-tool-list to get all tools

    @rhpvorderman
    rhpvorderman committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    7bfff03 View commit details
    Browse the repository at this point in the history

  8. Revert "use toolshed client to determine already installed repos" 

    This reverts commit c97e43c.
    @rhpvorderman
    rhpvorderman committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    abe0e78 View commit details
    Browse the repository at this point in the history

  9. add option to get_all_tools

    @rhpvorderman
    rhpvorderman committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    182ad7d View commit details
    Browse the repository at this point in the history

  10. add option to get all tool revisions to get-tool-list

    @rhpvorderman
    rhpvorderman committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    1ed4788 View commit details
    Browse the repository at this point in the history

  11. installed_tools now gets all tools

    @rhpvorderman
    rhpvorderman committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    ea85067 View commit details
    Browse the repository at this point in the history

  12. update test to reflect code

    @rhpvorderman
    rhpvorderman committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    11b9882 View commit details
    Browse the repository at this point in the history

  13. move some methods elsewhere

    @rhpvorderman
    rhpvorderman committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    e5c74d6 View commit details
    Browse the repository at this point in the history

  14. flake8 issues

    @rhpvorderman
    rhpvorderman committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    60e8215 View commit details
    Browse the repository at this point in the history

  15. combat complexity?

    @rhpvorderman
    rhpvorderman committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    0d0c599 View commit details
    Browse the repository at this point in the history

  16. fix data manager test

    @rhpvorderman
    rhpvorderman committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    8bb88c7 View commit details
    Browse the repository at this point in the history

  17. change defaults

    @rhpvorderman
    rhpvorderman committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    f3383d2 View commit details
    Browse the repository at this point in the history

  18. ignore CLI, set sane defaults

    @rhpvorderman
    rhpvorderman committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    e531eff View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2018

  1. Saner CLI interface regarding dependencies

    @rhpvorderman
    rhpvorderman committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    8973afc View commit details
    Browse the repository at this point in the history

  2. hide deprecated CLI functions

    @rhpvorderman
    rhpvorderman committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    31a089f View commit details
    Browse the repository at this point in the history

  3. fix documentation stuff

    @rhpvorderman
    rhpvorderman committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    e1a3053 View commit details
    Browse the repository at this point in the history

  4. fix conflicting true false storage in parser

    @rhpvorderman
    rhpvorderman committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    4adbb3f View commit details
    Browse the repository at this point in the history

  5. fix linting issue

    @rhpvorderman
    rhpvorderman committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    63bf514 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2018

  1. Fix extensions typo

    @mvdbeek
    mvdbeek committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    7a6dd40 View commit details
    Browse the repository at this point in the history

  2. Fix test_json default argument 

    This is needed when running `shed_tools test` without an explicit
`--test_json` argument.
    @mvdbeek
    mvdbeek committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    b6ea9e1 View commit details
    Browse the repository at this point in the history

  3. Only list repositories that are installed 

    Otherwise uninstalled repos would be listed, leading to `Skipped` when
you actually want to install them.
    @mvdbeek
    mvdbeek committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    7bc28cf View commit details
    Browse the repository at this point in the history

  4. Listing data managers requires API access

    @mvdbeek
    mvdbeek committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    57ac315 View commit details
    Browse the repository at this point in the history

  5. Avoid message attr when passing exception msg 

    This has been deprecated in python 3.
    @mvdbeek
    mvdbeek committed Aug 5, 2018
    1 Configuration menu
    Copy the full SHA
    16ede2a View commit details
    Browse the repository at this point in the history

  6. Use named attributes of namedtuple 

    Avoids mixups during tuple unpacking (wasn't broken here, but briefly
suspected it).
    @mvdbeek
    mvdbeek committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    a43bcdb View commit details
    Browse the repository at this point in the history

  7. Fix typo

    @mvdbeek
    mvdbeek committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    ed0ba61 View commit details
    Browse the repository at this point in the history

  8. Avoid testing all installed tools 

    if all tools are skipped or in error.
Skipped tools are still tested if `--test_exisiting` is passed.
    @mvdbeek
    mvdbeek committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    cd46a4f View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2018

  1. Merge pull request #3 from mvdbeek/rhpvorderman-refactor_shedtools 

    Rhpvorderman refactor shedtools
    @rhpvorderman
    rhpvorderman committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    c7bcbb5 View commit details
    Browse the repository at this point in the history

  2. rename ambigious tools to repos where applicable. Keep UI the same

    @rhpvorderman
    rhpvorderman committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    c652146 View commit details
    Browse the repository at this point in the history