Rhpvorderman refactor shedtools #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed when running `shed_tools test` without an explicit `--test_json` argument.
Otherwise uninstalled repos would be listed, leading to `Skipped` when you actually want to install them.
This has been deprecated in python 3.
Avoids mixups during tuple unpacking (wasn't broken here, but briefly suspected it).
if all tools are skipped or in error. Skipped tools are still tested if `--test_exisiting` is passed.
rhpvorderman
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all the things I mentioned in my review, have a look at the commit messages for details.