Also update data managers #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have been provided
1 task
|
Very nice - 👍 from me. Thanks a bunch @rhpvorderman ! |
jmchilton
approved these changes
Mar 12, 2018
bgruening
approved these changes
Mar 12, 2018
| @@ -152,9 +134,42 @@ def _parser(): | |||
| "Use this if you would like to use the list to update all the tools in" | |||
| "your galaxy instance using shed-install." | |||
| ) | |||
| parser.add_argument("-get_dms", "--get_data_managers", | |||
There was a problem hiding this comment.
Imho the single dashes are meant for single letter. I would skip the short version here.
5 tasks
|
@bgruening @jmchilton Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. This solves #69 .
Have not run extensive testing yet, but will do that tomorrow.
It seems to run for now. Curious to see your feedback.
One of the side effects is that
get-tool-listnow also usesget_galaxy_connectionmethod. a nice step towards unifying ephemeris.EDIT:
Changes:
shed-tools updatenow also updates data managers.get-tool-listyou can now also get all installed data managers, provided you have admin access to the galaxy.