Fix how elements inside macros are associated with their XSD definition #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests the name of the XSD element node associated with the XML element inside a `macros` section matches the expected node.
In case of an element defined inside a `macros` tag the XSD node associated will be determined by name intead of by the tree path
This will retun None for XML elements that can not be associated with a corresponding XSD definition instead of returning always the root `tool` element. Some tests had to be fixed to check this new behaviour.
davelopez
added
bug
bgruening
approved these changes
Feb 13, 2021
|
Oh shit this is pretty cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107
The auto-completion, documentation on hover, and basically all the features based on XSD definitions were broken when the elements were inside a
macrossection. This was caused by how the associated XSD elements were determined based on the 'tree hierarchy' of the XML element. When an XSD element can not be associated, the default root (tool) element was used, which was confusing. In the case of elements inside macros, the XSD hierarchy can not be used (as they do not match) so a new 'name-based' solution was used instead.Now the elements under a
macrossection (or in an externalmacros.xmlfile) can benefit from the auto-completion and other XSD based features 馃帀Thank you @sunyi000 for reporting this!