Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong argument in get_content_range #178

Merged
merged 1 commit into from Oct 16, 2021

Conversation

davelopez
Copy link
Collaborator

Fixes #177

When creating a Code Action (after selecting a block of XML) to extract a part of the tool as a macro, if there were no macros section defined, the wrong type of parameter could be passed to the get_content_range function to determine the insert position, resulting in an error.

@davelopez davelopez added bug Something isn't working language server Related to the language server labels Oct 16, 2021
@davelopez davelopez added this to the v0.7.0 milestone Oct 16, 2021
@bgruening bgruening merged commit 2076440 into master Oct 16, 2021
@bgruening bgruening deleted the fix_macros_insert_position branch October 16, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working language server Related to the language server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when selecting text range in some situations
2 participants