Migrate to pygls v1 #216
Merged
Migrate to pygls v1 #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The definitions_provider might not be initialized until the client configuration has been provided to the server with the workspace information.
davelopez
added
enhancement
Add python 3.10 and use node 18
davelopez
force-pushed
the
migrate_pygls_1.0.1
branch
from
8641fa1
to
dc31613
Compare
davelopez
force-pushed
the
migrate_pygls_1.0.1
branch
from
1b15d1c
to
123e630
Compare
davelopez
force-pushed
the
migrate_pygls_1.0.1
branch
from
123e630
to
8701bbb
Compare
davelopez
force-pushed
the
migrate_pygls_1.0.1
branch
from
35da25c
to
0287a3f
Compare
|
After quite some debugging I figured out the problem with Python 3.11 in the Extension CI tests... The problem is that the previous version of the galaxy-language-server (prior to this PR) does not support Python 3.11 and that version is the one that gets installed from pypi to run the tests until a new version is released... so I'm going to merge this and cut a new version of the server 🤦♂️ |
|
:-) Thanks @davelopez |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to
pyglsversion 1.0.1 following the migration guide.Mostly update imports and switch from pydantic custom models to attrs and cattrs for serialization and deserialization.