Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Cloud Authorization menu should not be enabled by default #10922

Open
mvdbeek opened this issue Dec 15, 2020 · 1 comment
Open

Manage Cloud Authorization menu should not be enabled by default #10922

mvdbeek opened this issue Dec 15, 2020 · 1 comment
Assignees
Labels
area/auth Authentication and authorization kind/bug

Comments

@mvdbeek
Copy link
Member

mvdbeek commented Dec 15, 2020

I believe this currently doesn't do anything, and this is confusing users (https://help.galaxyproject.org/t/galaxy-doesnt-allow-cloud-authorization-save-key-button-deactivated/4878).
The link to the documentation is broken as well.

@VJalili can you have a look at this please?

@mvdbeek mvdbeek added kind/bug area/auth Authentication and authorization labels Dec 15, 2020
@VJalili
Copy link
Member

VJalili commented Dec 15, 2020

Cloud authz is required for the cloud storage API.

Both cloud authz and cloud storage are API-based functionalities. When designing these, we had a discussion on whether we should enable/disable APIs. Enabling or disabling some API endpoints is usually conceived as an anti-pattern, and, at least back then, neither Galaxy had any functionality to enable/disable some APIs nor we were aware of any API endpoints enabled/disabled on different instances. Therefore, we did not implement any means of enabling/disabling this UI, instead, we took the approach of implementing and merging the dependencies first. So, first OIDC, then authz, then cloud storage.

However, these APIs may not function properly (e.g., AWS will not work) if OIDC is not enabled, and that is the case on Main. Maybe this could be a motivation to commit to enabling OIDC on Main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auth Authentication and authorization kind/bug
Projects
None yet
Development

No branches or pull requests

2 participants