Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link in pop-up window after Data Library to History import does not work #15848

Closed
lldelisle opened this issue Mar 27, 2023 · 4 comments
Closed

Comments

@lldelisle
Copy link
Contributor

Describe the bug
When you import a dataset from data library to history a green rectangle appear but when you click on it it does not work

Galaxy Version and/or server at which you observed the bug
usegalaxy.eu and usegalaxy.org

To Reproduce
Steps to reproduce the behavior:

  1. Go to Data Library
  2. Select a dataset
  3. Click to import into history
  4. Try to click on the green rectangle, nothing happens.

Expected behavior
I expect that when you click on the box it brings you to the history.

Screenshots
image

@hujambo-dunia
Copy link
Contributor

Hi @ElectronicBlueberry, it appears that a change made in this commit replacing the "toaster" feature reference ui/toast with a new JS library called composables/toast is the cause of the issue because the new JS library is missing a Promise feature where an on-click event could reside. Perhaps there was a security issue with the prior JS library's promise feature which is why it was removed...? What are your thoughts?

Option 1) Shall I go ahead and add a Promise feature to the composables/toast class? @dannon Do we want clickable "toaster" feature?

Option 2) Alternatively, replacing this line (with either below optional modules) fixes the issue but fundamentally changes the UI/design (but design is a straightforward change).
Either of the below work in place of this line allowing the "toaster" feature to be clickable:
import { Toast } from "ui/toast"
import * as Toast from "toastr"
Greenshot 2023-04-26 07 49 03

@dannon
Copy link
Member

dannon commented Apr 26, 2023

We don't want to swap back to the old toast, the modernized composable is the way to go. The old library was toastr, but the new composable uses a (more native for us, at least) bootstrap-vue based toast.

The contents just need to be clickable. You want https://bootstrap-vue.org/docs/components/toast#links

@hujambo-dunia
Copy link
Contributor

@dannon Thanks for the URL! Our code has a pass-through component where the href parameter got dropped, so my PR (which is ready for review) adds the param back and references it in the code.

@dannon
Copy link
Member

dannon commented Apr 27, 2023

Fixed in #16008

@dannon dannon closed this as completed Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants