Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ill-defined behavior of Import history from archive #18047

Open
wm75 opened this issue Apr 23, 2024 · 3 comments
Open

Ill-defined behavior of Import history from archive #18047

wm75 opened this issue Apr 23, 2024 · 3 comments

Comments

@wm75
Copy link
Contributor

wm75 commented Apr 23, 2024

Describe the bug
When you select an archive that is not exactly an archived history under Import history from archive, then there is no strict checking but the import may fail with various messages, or in the succeed with side-effects.

Galaxy Version and/or server at which you observed the bug
tested on usegalaxy.eu

To Reproduce

  • If you import a Workflow Run RO-Crate (exported from the workflow invocations page) as a history, you will get a WF added to your WFs, a WF invocation added to your invocations, and datasets added to your current history, but the UI will tell you that it just imported a history.
  • If you import a WF invocation exported in "Galaxy native format" (essentially, like a RO-Crate but without datasets), you will also get a WF and an invocation added, but only the last changed date of your current history updated

Expected behavior
While it's super-nice that you can import workflow invocations just like that, it would be better if the History import only accepted history archives and the WF invocations import was moved to separate functionality.
It would also be good if the WF invocations import would (just like the workflow run dialog) ask you if you want to import the invocation datasets into your current history or into a new one.

Both importers should check their inputs and refuse to work with unexpected formats.

@hexylena
Copy link
Member

In theory I like the behaviour of "import in one place and get notified" xref #10695, if only notifications were generated for the user of "hey we also imported a history" and "hey we also imported an invocation" and "hey we also found datasets".

@ahmedhamidawan
Copy link
Member

Imported invocations can also mess up the step order as can be seen here:

The imported invocation (on top) has the final step of the workflow as the first step instead

@mvdbeek
Copy link
Member

mvdbeek commented May 6, 2024

That seems like a different issue, can you post an example workflow as a separate issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants