Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch operation loading stuck in History panel when adding or removing tags #18056

Closed
itisAliRH opened this issue Apr 25, 2024 · 5 comments · Fixed by #18068
Closed

Batch operation loading stuck in History panel when adding or removing tags #18056

itisAliRH opened this issue Apr 25, 2024 · 5 comments · Fixed by #18068

Comments

@itisAliRH
Copy link
Member

Batch operation loading stuck in History panel:

proccess.mp4

Galaxy Version and/or server at which you observed the bug
Galaxy Version: (check <galaxy_url>/api/version if you don't know)
Commit: (run git rev-parse HEAD if you run this Galaxy server)

Browser and Operating System
Operating System: Windows, Linux, macOS
Browser: Firefox, Chrome, Chrome-based, Safari

To Reproduce
Steps to reproduce the behavior:

  1. Go to Current History
  2. Select few datasets
  3. Run an operation with selected items (like adding a tag)
  4. See the loading stuck in the datasets list until refreshing the page

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@davelopez
Copy link
Contributor

davelopez commented Apr 25, 2024

This might be a regression, the factor that makes the Processing operation look like is spinning forever is that there is no update_time change triggered in the current history for some reason.

Does it happen to all operations or just with tags?

@itisAliRH
Copy link
Member Author

@davelopez It only happens on the Add tags and Remove tags operations because changing tags does not change the history update_time (for all histories).
I think we should do nothing after these operations like Build dataset pair operation etc.

@itisAliRH
Copy link
Member Author

History pulling is not getting the tag updates until searching or opening a collection.

@davelopez
Copy link
Contributor

History pulling is not getting the tag updates until searching or opening a collection.

That is because of the same reason, if the history update_time doesn't change after the operation, the history watcher doesn't know it needs to get new updates. I'll investigate why it is not getting triggered now.

@davelopez davelopez self-assigned this Apr 29, 2024
@davelopez davelopez changed the title Batch operation loading stuck in History panel Batch operation loading stuck in History panel when adding or removing tags Apr 29, 2024
@davelopez
Copy link
Contributor

Should be fixed in #18068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants