Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History - "For all selected" doesn't work across pages #4350

Closed
blankclemens opened this issue Jul 27, 2017 · 12 comments
Closed

History - "For all selected" doesn't work across pages #4350

blankclemens opened this issue Jul 27, 2017 · 12 comments

Comments

@blankclemens
Copy link
Member

When working with histories containing more than one page, the For all selected... button only takes the elements from the visible page.

This is for example necessary for Build List of Dataset Pairs or Build Dataset List if the elements of interest are not on the same page by chance (or are just too many for one page).

I couldn't find a workaround as a user (e.g. deactivating pages) - since it removes the functionality to build these collections, I consider this quite important.

@nekrut
Copy link
Contributor

nekrut commented Jul 27, 2017

This is a major issue!

@mvdbeek
Copy link
Member

mvdbeek commented Jul 27, 2017

That's a duplicate of #3911. Or at least they're linked.

@mvdbeek mvdbeek marked this as a duplicate of #3911 Jul 27, 2017
@blankclemens
Copy link
Member Author

Indeed it is, my bad, was focused to much on "For all selected" to find this issue.

@mvdbeek
Copy link
Member

mvdbeek commented Jul 27, 2017

I couldn't find a workaround as a user (e.g. deactivating pages) - since it removes the functionality to build these collections, I consider this quite important.

One workaround is to create 2 collections, and then you should be able to merge them. Less than ideal, but if you do need to do this a lot right now it may help

@blankclemens
Copy link
Member Author

blankclemens commented Jul 28, 2017

@mvdbeek Thanks, I didn't know that I can merge collections. But to use this, I still need to have my pairs on one page - e.g. having a page with 500 forward reads and a page with 500 reverse reads wont be solvable through this, or am I missing something?

Another workaround: Upload all files again (which might take hours cause of #4347 and #1090) and use the history directly afterwards to create the collections, since the pages haven't been generated yet. Just don't reload the page until you're finished! ;)

While it makes sense to close duplicates, shouldn't we at least merge the labels to the remaining open issue, since this is quite major?

@mvdbeek
Copy link
Member

mvdbeek commented Jul 28, 2017

@mvdbeek Thanks, I didn't know that I can merge collections. But to use this, I still need to have my pairs on one page - e.g. having a page with 500 forward reads and a page with 500 reverse reeds wont be solvable through this, or am I missing something?

Yes, you're right. In principle you could use the Zip Collection tool to merge forward and reverse, but that is getting a bit more complicated ...

I'm inclined to close the other one, since there is more information in here.

@mvdbeek
Copy link
Member

mvdbeek commented Jul 28, 2017

@dannon you assigned yourself to #3911, do you want to take on this issue ?

@dannon
Copy link
Member

dannon commented Aug 7, 2017

@mvdbeek I will eventually, but I'm happy for anyone else interested to pick it up and run with it. I've been out of action having a kid and stuff, and probably won't get to this in the very near future.

Pending a more comprehensive selector dialog solution, the easiest fix that popped into my mind last time I looked at this was to just to have a button on the history to 'load it all' spanning pagination. There are definitely performance concerns to look into and test with very large histories, but that was going to be my first stab at it.

@mvdbeek
Copy link
Member

mvdbeek commented Aug 7, 2017

Thanks @dannon, I totally get that, hope all is well!
I'll add this to the 17.09 milestone, and we'll see if someone picks it up :).

@mvdbeek mvdbeek added this to the 17.09 milestone Aug 7, 2017
@natefoo natefoo modified the milestones: 18.01, 17.09 Sep 7, 2017
@blankenberg
Copy link
Member

Bumping into this as well...

@martenson martenson modified the milestones: 18.01, 18.05 Jan 25, 2018
@jmchilton jmchilton modified the milestones: 18.05, 18.09 Apr 19, 2018
@dannon dannon modified the milestones: 18.09, 19.01 Sep 6, 2018
@jmchilton jmchilton removed this from the 19.01 milestone Dec 12, 2018
@dannon
Copy link
Member

dannon commented Jan 28, 2021

This is on the Q1 UI-UX roadmap to be addressed in the new history.

@mvdbeek mvdbeek modified the milestones: 21.01, 21.05 Jan 30, 2021
@mvdbeek mvdbeek modified the milestones: 21.05, 21.09 May 6, 2021
@mvdbeek mvdbeek modified the milestones: 21.09, 22.01 Sep 28, 2021
@dannon dannon modified the milestones: 22.01, 22.05 Jan 11, 2022
@dannon dannon self-assigned this Jan 11, 2022
@dannon
Copy link
Member

dannon commented May 12, 2022

This is resolved with the new history and bulk operations.

@dannon dannon closed this as completed May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants