Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule Builder / Uploader Issues for Iteration 1 #5380

Closed
13 of 19 tasks
jmchilton opened this issue Jan 24, 2018 · 1 comment
Closed
13 of 19 tasks

Rule Builder / Uploader Issues for Iteration 1 #5380

jmchilton opened this issue Jan 24, 2018 · 1 comment

Comments

@jmchilton
Copy link
Member

jmchilton commented Jan 24, 2018

Issues / Bugs:

  • Issue a warning to the user if they attempt to run this with non HDAs for now. (Reported by @mvdbeek.) a29a42a
  • Everything breaks if a regex is invalid - I baked in some error handling and display but not for this it seems. (Reported by @mvdbeek.) 755d865
  • No warning on jagged tables - it just renders only the number of columns in the first row. 4997ba6
  • Column labels are only assigned on the result - so the description of the columns can be quite off. We could either remove this information (so display "concatenate columns" instead of "concatenate columns A and B" or track the column information over time and render the right label for the corresponding operation step). By the same token editing rules originally added earlier in the rules list results in showing the final resulting columns. c2527f5
  • Update job state and display warning about longer jobs in fetch API mode. eebb084
  • Only display FTP-related information and options if FTP is enabled. d29ce13
  • Jobs are not displayed in the history panel at all - and the fetch tool doesn't have any fixed outputs so if the user dismisses the dialog that monitors the upload or leaves and comes back - they don't status updates and need to refresh the history to see the final result. We could tweak the API to pre-create the outputs specified or we could do what a lot of tools do and just add a log of the outputs that is always created. We could throw some information in there. Tweaked the API to pre-create datasets and/or a collection outline Pre-create certain outputs for upload 2.0 API. #5609 99a93f7
  • Sometimes horizontally scrolling the data seems broken. (Reported by @mvdbeek.) 4997ba6
  • Fixing the above item seems to have added double scroll bars to the table in the screenshots from the Selenium tests.
  • Sort seems to be pretty broken.
  • Eliminate multi-select for list identifiers - they are ordered - need something like individual selectors and a button to add new ones.

Enhancements:

  • Add drop target for text datasets. (Suggested by @mvdbeek.)
  • Display column definitions in the table in some way. 72b0726
  • Separate but related to the above - allow column headers from the original data.
  • New filter - contains value.
  • New column adder - regex with specified number of groups to capture (makes splitting much easier for instance). (Re-did regex column adder - has different modalities including this.)
  • Add checkbox requiring multiple collections to be matching - currently one can create two collections with the same structure but there is no way to force that they are the same structure and warn if they aren't. Would then implement UI to Support Creation of Matching Lists #3916.
  • Handle mouse-over for rules:
    • High-light columns of the table for various column addition operations.
    • Display filter statistics.
  • Allow setting path for admins.
@nuwang
Copy link
Member

nuwang commented Feb 27, 2018

@jmchilton Just wanted to flag this issue: #4443 since you seem to be heavily refactoring the uploader. It would be great if the data source tools and upload tool can be made consistent when it comes to compressed file handling.

@jmchilton jmchilton changed the title Rule Builder / Uploader Issues Rule Builder / Uploader Issues for Iteration 1 Apr 1, 2018
@jmchilton jmchilton added this to Done in Collections Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Collections
  
Done
Development

No branches or pull requests

2 participants