Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete_current history - dangerous #894

Closed
scholtalbers opened this issue Oct 12, 2015 · 3 comments
Closed

Delete_current history - dangerous #894

scholtalbers opened this issue Oct 12, 2015 · 3 comments
Assignees
Labels

Comments

@scholtalbers
Copy link
Contributor

So...I just screwed up pressing permanently delete on my active history. However, just before, in a different firefox tab I impersonated someone and did not log out but just forgot about it..this resulted in Galaxy deleting his current active history, not the one I was seeing in the active window/tab.

Can this button maybe contain the history id that is visible in the active tab and not call delete_current?

@martenson
Copy link
Member

Being id-specific for non-reversible actions sounds very reasonable to me. Ping @carlfeberhard

@dannon
Copy link
Member

dannon commented Oct 12, 2015

As far as I know, the plan has always been to remove all notion of "current" history from the API, and require specific identifiers for everything. These non-reversible actions seem like a really, really great early target. +1

@hexylena
Copy link
Member

(It sure would be nice if "delete permanently" was only an option once something was deleted. Thus requiring that it first go through the reversible "deleted" state, rather than a one way ticket to /dev/null)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants