Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrated_tools_conf should be in mutable_config_dir #9376

Closed

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Feb 14, 2020

This used to be in config_dir by default, but should be in mutable_confiig_dir.

  1. Keep it consistent with ansible-galaxy. (as per discussion with @natefoo)
  2. Also, correct description of integrated_tool_panel_config (unrelated minor fix)

Context:

@jdavcs jdavcs added kind/bug area/configuration Galaxy's configuration system labels Feb 14, 2020
@jdavcs jdavcs added this to the 20.05 milestone Feb 14, 2020
@jdavcs
Copy link
Member Author

jdavcs commented Feb 14, 2020

Failed unit test is unrelated. All pass.

@nsoranzo
Copy link
Member

@jdavcs jdavcs force-pushed the dev_config_migrated_tools_conf branch from 5653e34 to e6e8487 Compare February 17, 2020 19:48
@jdavcs
Copy link
Member Author

jdavcs commented Feb 17, 2020

@nsoranzo do you mean target only that release, or target dev + 19.09 (and then 20.01 too?)

@mvdbeek
Copy link
Member

mvdbeek commented Feb 18, 2020

Just 19.09 is fine, we can merge forward then.

jdavcs added a commit to jdavcs/galaxy that referenced this pull request Feb 18, 2020
Backport galaxyproject#9376

1. Keep it consistent with ansible-galaxy.

2. Correct description of integrated_tool_panel_config.
1. Keep it consistent with ansible-galaxy.

2. Correct description of integrated_tool_panel_config.
@jdavcs jdavcs force-pushed the dev_config_migrated_tools_conf branch from e6e8487 to cc96104 Compare February 18, 2020 20:53
@jdavcs jdavcs removed the status/WIP label Feb 19, 2020
nsoranzo added a commit that referenced this pull request Feb 19, 2020
[19.09] Move migrated_tools_conf > mutable_config_dir (#9376)
@nsoranzo nsoranzo closed this Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration Galaxy's configuration system kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants