Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolshed is unhappy with HTML content, planemo errors on upload. #992

Closed
hexylena opened this issue Oct 26, 2015 · 5 comments · Fixed by #4082
Closed

Toolshed is unhappy with HTML content, planemo errors on upload. #992

hexylena opened this issue Oct 26, 2015 · 5 comments · Fixed by #4082
Assignees
Milestone

Comments

@hexylena
Copy link
Member

hxr@leda:~/work/tools-iuc/tools/macs2$ planemo shed_update -t testtoolshed --force_repository_creation .
cd '/home/hxr/work/tools-iuc/tools/macs2' && git rev-parse HEAD
cd '/home/hxr/work/tools-iuc/tools/macs2' && git diff --quiet
Could not update macs2
Unexpected response from galaxy: 400: {"content_alert": "The file \"/srv/toolshed/test/var/data/repos/000/repo_749/dir2html.py\" contains HTML content.\n", "e
rr_msg": "No changes to repository."}
Repository metadata updated.
Failed to update a repository.
hxr@leda:~/work/tools-iuc/tools$ planemo shed_update -t testtoolshed --force_repository_creation gatk2/
cd '/home/hxr/work/tools-iuc/tools/gatk2' && git rev-parse HEAD
cd '/home/hxr/work/tools-iuc/tools/gatk2' && git diff --quiet
Could not update gatk2
Unexpected response from galaxy: 400: {"content_alert": "The file \"/srv/toolshed/test/var/data/repos/000/repo_674/gatk2_wrapper.py\" contains HTML content.\n
The file \"/srv/toolshed/test/var/data/repos/000/repo_674/test-data/gatk/gatk_analyze_covariates/gatk_analyze_covariates_out_1.html\" contains HTML content.\n
", "err_msg": "No changes to repository."}
Repository metadata updated.
Failed to update a repository.

@martenson I'll help however I can. We're TWO tool repositories away from 100% parity between TTS and github. I want to resolve this :)

@martenson martenson added this to the 16.01 milestone Nov 26, 2015
@martenson martenson modified the milestones: 16.04, 16.01 Jan 6, 2016
@martenson martenson modified the milestones: 16.07, 16.04 Apr 5, 2016
@hexylena
Copy link
Member Author

hexylena commented May 3, 2016

And again

Unexpected response from galaxy: 500: {"content_alert": "The file \"/srv/toolshed/test/var/data/repos/002/repo_2815/json2iframe.py\" contains HTML content.\n",

it's supposed to have HTML content. That's the purpose of that tool!
I'll base64 encode it to make the TS happy but that seems ridiculous.

@remimarenco
Copy link
Contributor

I +1 on this. I was really suprised, and it is quite blocking for (my main) tool development.

@martenson
Copy link
Member

martenson commented May 4, 2016

hear, hear

@dannon
Copy link
Member

dannon commented Jul 27, 2016

The HTML content issue was a red herring, and shouldn't be presented to the user as an error here. @remimarenco's issue that presented this same way was a datatypes_conf.xml in the tool tarball that referenced a datatype that didn't exist.

I'll follow up here and close this with more details, but the toolshed does allow html content uploads. The content_alert is actually composed to allow notification of toolshed admins when potentially inappropriate content is uploaded, and it does not actually block the upload.

@martenson martenson assigned dannon and unassigned martenson Jul 27, 2016
@dannon dannon modified the milestones: 16.10, 16.07 Jul 29, 2016
@remimarenco
Copy link
Contributor

Yes, exactly as @dannon said. The message error does not match the true issue. I believe this is a need to fix the exception raised in ToolShed?

@martenson martenson modified the milestones: 17.01, 16.10 Nov 16, 2016
@martenson martenson self-assigned this Jan 12, 2017
@martenson martenson modified the milestones: 17.05, 17.01 Jan 12, 2017
@martenson martenson added this to the 17.09 milestone May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants